As a public service, I point you to the Microsoft online password strength checker.

Of course, the XKCD comic on passwords is really the last word on the subject.